media: Wire URL player duration and buffered ranges for tvOS by abhijeetk · Pull Request #11548 · youtube/cobalt

abhijeetk · 2026-07-25T07:05:53Z

Plumb duration and buffered time range reporting from the URL player
through StarboardRenderer, StarboardRendererWrapper, Mojo IPC, and
UrlPlayerDemuxer. This ensures that the JavaScript video.duration and
video.buffered APIs correctly reflect the underlying platform player
state on tvOS.

Duration is reported once when the player reaches the presenting state.
Buffered ranges are polled via GetMediaTime on each timer tick to
provide continuous updates to the web application.

Blocked by #10698

Bug: 512045535

github-actions · 2026-07-25T07:06:08Z

🤖 Gemini Suggested Commit Message

media: Wire URL player duration and buffered ranges

Plumb duration and buffered time range reporting from the URL player
through StarboardRenderer, StarboardRendererWrapper, Mojo IPC, and
UrlPlayerDemuxer. This ensures that the JavaScript video.duration and
video.buffered APIs correctly reflect the underlying platform player
state on tvOS.

Duration is reported once when the player reaches the presenting state.
Buffered ranges are polled via GetMediaTime on each timer tick to
provide continuous updates to the web application.

Bug: 512045535

💡 Pro Tips for a Better Commit Message:

Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
Re-run the Generator: Post a comment with: /generate-commit-message

abhijeetk · 2026-07-27T19:07:53Z

cc : @Gyuyoung @jkim-julie @rakuco

gemini-code-assist

Code Review

This pull request introduces support for a URL-based player (URL player) on iOS/tvOS platforms using Starboard media, adding UrlPlayerDemuxer and UrlPlayerDemuxerStream as placeholders, and integrating them with StarboardRenderer and StarboardRendererClient. The review feedback recommends adding class comments to the new classes per the style guide, adding defensive null checks for player_bridge_ to prevent potential crashes, using DCHECK instead of CHECK for sequence verification, and aligning preprocessor guards to BUILDFLAG(IS_IOS_TVOS) && BUILDFLAG(USE_STARBOARD_MEDIA) to avoid compilation failures in non-Starboard configurations.

Add URL player support to StarboardRenderer for native HLS playback. UrlPlayerDemuxer provides placeholder streams for pipeline init while the platform player handles actual playback via SetSourceUrl. Bug: 512045535

through StarboardRenderer, StarboardRendererWrapper, Mojo IPC, and UrlPlayerDemuxer. This ensures that the JavaScript video.duration and video.buffered APIs correctly reflect the underlying platform player state on tvOS. Duration is reported once when the player reaches the presenting state. Buffered ranges are polled via GetMediaTime on each timer tick to provide continuous updates to the web application. Blocked by youtube#10698 Bug: 512045535

borongc · 2026-07-28T20:13:16Z

 #include "media/base/media_switches.h"
 #include "media/base/renderer_factory.h"
 #include "media/base/starboard/experimental_features.h"
+#include "media/media_buildflags.h"


I don't think including this is necessary.

The comments of this PR should be applied to #10698.

borongc · 2026-07-28T20:13:57Z

 #include "third_party/blink/public/web/web_view.h"
 #include "ui/gfx/geometry/size_conversions.h"

+#if BUILDFLAG(IS_IOS_TVOS) && BUILDFLAG(USE_STARBOARD_MEDIA)


USE_STARBOARD_MEDIA is true for Cobalt build anyway, so this is not necessary.

borongc · 2026-07-28T20:14:42Z

  kFrameInjectingDemuxer = 5,
  kStreamProviderDemuxer = 6,
  kManifestDemuxer = 7,
+  kUrlPlayerDemuxer = 8,  // URL player placeholder demuxer.


nit: gate it by BUILDFLAG(USE_STARBOARD_MEDIA).

borongc · 2026-07-28T20:15:02Z

 #include "media/base/media_resource.h"

 #include "base/no_destructor.h"
+#include "media/media_buildflags.h"


This is not necessary, please check it.

borongc · 2026-07-28T20:15:36Z

 #include "media/base/demuxer_stream.h"
 #include "media/base/media_export.h"
+#include "build/build_config.h"
+#include "media/media_buildflags.h"


Same for all #include "media/media_buildflags.h"

borongc · 2026-07-28T20:17:53Z


-  if (base::FeatureList::IsEnabled(kCobaltBypassMojoForMedia) ||
-      bypass_mojo_for_media_) {
+  // URL player is incompatible with the bypass bridge because the bypass


You can just gate the code by !BUILDFLAG(IS_IOS_TVOS)

Thanks for the suggestion!

Gating the bypass bridge block with !BUILDFLAG(IS_IOS_TVOS) would also require gating the related members (bypass_mojo_for_media_, bypass_bridge_, bypass_id_), the static g_next_bypass_id, and the three helper methogs (OnTimeUpdateFromBridge, OnStatisticsUpdateFromBridge OnExtensionBypassInitialized), since they become unused on tvOS and trigger -Werror compile errors.

Let me know if you'd prefer a different approach here.

borongc · 2026-07-28T20:19:00Z

  void PaintVideoHoleFrame(const gfx::Size& size) override;
  void UpdateStarboardRenderingMode(const StarboardRenderingMode mode) override;
  void GetSbWindowHandle() override;
+  void OnDurationChange(base::TimeDelta duration) override;


As this is only used on tvOS, consider to gate them by BUILDFLAG(IS_IOS_TVOS), so it would override on other platforms. Same for OnBufferedTimeRangesChange.

borongc · 2026-07-28T20:19:46Z

  kFrameInjectingDemuxer = 5,
  kStreamProviderDemuxer = 6,
  kManifestDemuxer = 7,
+  kUrlPlayerDemuxer = 8,  // URL player placeholder demuxer.


please gate it.

is_ios_tvos / is_tvos isn't available as a mojom enabled feature (only is_ios is registered in mojom.gni). Would [EnableIf=is_ios] work as a substitute since it's the closest available flag?

Currently at GN level, we identify tvos code using is_ios && target_platform == "tvos" but we can not use compound conditions with [EnableIf=...]

Please see our previous notes here regarding this constraint.

Aslo, media_types.mojom must stay in sync with demuxer.h and media_types_enum_mojom_traits.h.
The traits file has a switch that maps between ::media::DemuxerType::kUrlPlayerDemuxer (from
demuxer.h) and media::mojom::DemuxerType::kUrlPlayerDemuxer (from generated mojom). If one exists but the other doesn't, compilation fails.

As per your suggestion on demuxer.h to use BUILDFLAG(USE_STARBOARD_MEDIA), it means we need to use [EnableIf=use_starboard_media] here ?

borongc · 2026-07-28T20:20:54Z

  GetSbWindowHandle();

+  // URL player duration and buffered ranges forwarding.
+  OnDurationChange(mojo_base.mojom.TimeDelta duration);


Please gate it both by use_starboard_media and is_ios_tvos

As discussed above on media_types.mojom, is_ios_tvos isn't available as a mojom enabled feature.
The interface StarboardRendererClientExtension is already guarded by use_starboard_media, should we use [EnableIf=is_ios] here ?

borongc · 2026-07-28T20:21:04Z

  InitializeWithBypassBridge(uint32 bypass_bridge_id) => (bool success);

+  // Pass source URL for URL player.
+  SetSourceUrl(string source_url);


As discussed above on media_types.mojom, is_ios_tvos isn't available as a mojom enabled feature.
The interface StarboardRendererExtension is already guarded by use_starboard_media, should we use [EnableIf=is_ios] here ?

abhijeetk self-assigned this Jul 25, 2026

abhijeetk requested review from borongc, fayev-g and jasonzhangxx July 27, 2026 19:06

abhijeetk marked this pull request as ready for review July 27, 2026 19:11

abhijeetk requested review from a team as code owners July 27, 2026 19:11

gemini-code-assist Bot reviewed Jul 27, 2026

View reviewed changes

abhijeetk added 2 commits July 29, 2026 00:02

media: Implement URL player for native HLS on tvOS

c280e82

Add URL player support to StarboardRenderer for native HLS playback. UrlPlayerDemuxer provides placeholder streams for pipeline init while the platform player handles actual playback via SetSourceUrl. Bug: 512045535

abhijeetk force-pushed the wiring-up-duration-and-buffer-ranges branch from 995ec4c to 4d11882 Compare July 28, 2026 19:00

borongc reviewed Jul 28, 2026

View reviewed changes

borongc mentioned this pull request Jul 28, 2026

tvos: Implement UrlPlayer for native HLS playback #10698

Open

Uh oh!

Conversation

abhijeetk commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 25, 2026

🤖 Gemini Suggested Commit Message

Uh oh!

abhijeetk commented Jul 27, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

borongc Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhijeetk Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

abhijeetk commented Jul 25, 2026 •

edited

Loading

borongc Jul 28, 2026 •

edited

Loading

abhijeetk Jul 29, 2026 •

edited

Loading